Skip to content

83 new noderegistration fixbodybytes #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 6, 2019
Merged

83 new noderegistration fixbodybytes #126

merged 10 commits into from
Aug 6, 2019

Conversation

iltoga
Copy link
Contributor

@iltoga iltoga commented Aug 6, 2019

Description

Improve code quality in respect of DTO serialization/deserialization and unit testing of serialized data

Breakdown

  • Added file to transcode field names into their size (in bytes) to be used to parse/get bytes to/from models when serializing/deserializing
  • Refactored code in transaction.GetBytes and transaction.ParseBytes implementations
  • Fixed unit tests

Reference Issue

Close #100

stefano galassi and others added 6 commits August 5, 2019 19:20
WIP: fixing tests
27bd679
added fixtureGenerator for tests
48a18b4 
added Get/Parse bytes to TypeAction interface
TODO: interface  for transactionBody to be returned by ParseBodyBytes
@andy-shi88
#83 cast transaction body interface to specific body implementation
68f1586
fixed transaction.go instantiating sendMoney variable
1b43bb3
Merge remote-tracking branch 'origin/develop' into 83-new-noderegistr…
1e93674 
…ation-fixbodybytes
added exclude-rule for isTxBody() unused method, since it's used to f…
261bae3 
…orce TransactionBodyInterface implementation by all transaction body types
@iltoga iltoga self-assigned this Aug 6, 2019
@iltoga iltoga requested a review from andy-shi88 August 6, 2019 06:24
@iltoga iltoga added the FEATURE New feature or request label Aug 6, 2019
@iltoga iltoga added this to the Sprint 3 milestone Aug 6, 2019
@iltoga iltoga requested a review from astaphobia August 6, 2019 06:25
@astaphobia astaphobia merged commit ec37762 into develop Aug 6, 2019
@astaphobia astaphobia deleted the 83-new-noderegistration-fixbodybytes branch August 6, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-shi88 andy-shi88 andy-shi88 approved these changes

@astaphobia astaphobia Awaiting requested review from astaphobia

Assignees

@iltoga iltoga

Labels
FEATURE New feature or request
Projects
None yet
Milestone
Sprint 3
Development

Successfully merging this pull request may close these issues.
3 participants
@iltoga @andy-shi88 @astaphobia